You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removes @Skip annotations from scenarios C2438, C2439, and C2440 in SavingsAccount.feature.
These scenarios were skipped because SavingsAccountRequestFactory hardcoded
EUR_SAVING_PRODUCT_ID = 1L which did not exist in the E2E environment.
PR #5646 fixed the root cause by dynamically creating the EUR savings product via
SavingsProductRequestFactory.defaultSavingsProductRequest() and storing its ID in
TestContextKey.DEFAULT_SAVINGS_PRODUCT_CREATE_RESPONSE_EUR.
The "And Admin creates a EUR savings product" step is now added to C2438, C2439,
and C2440 (already present in C2441 from PR #5646), making the skip reason obsolete.
@adamsaghy As requested, removed the @Skip tags from C2438, C2439, and C2440.
Added the "And Admin creates a EUR savings product" step to each scenario to
dynamically create the product, same approach as C2441 in PR #5646.
@adamsaghy During CI, scenarios C2439, C2440, and C2441 were failing with a 403
"Unknown data integrity issue with savings product" error. The root cause was that
SavingsProductRequestFactory.defaultSavingsProductRequest() used a hardcoded product
name "CEUR" — when multiple scenarios run sequentially in the same DB session, the
second scenario hits a unique constraint violation trying to create a product with
the same name.
Fixed by appending a 4-character UUID suffix to both the product name and short name,
making each scenario's product creation independent. All 43 checks are now passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes @Skip annotations from scenarios C2438, C2439, and C2440 in SavingsAccount.feature.
These scenarios were skipped because SavingsAccountRequestFactory hardcoded
EUR_SAVING_PRODUCT_ID = 1L which did not exist in the E2E environment.
PR #5646 fixed the root cause by dynamically creating the EUR savings product via
SavingsProductRequestFactory.defaultSavingsProductRequest() and storing its ID in
TestContextKey.DEFAULT_SAVINGS_PRODUCT_CREATE_RESPONSE_EUR.
The "And Admin creates a EUR savings product" step is now added to C2438, C2439,
and C2440 (already present in C2441 from PR #5646), making the skip reason obsolete.
Closes FINERACT-2533